GLES3: Fix glMapBufferRange
return null when r_index + last_item_index > max_instance
#81036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #80986.
The origin code has bug because when
r_index == data.max_instances_per_buffer
, glMapBufferRange trys to map length =data.max_instances_per_buffer * sizeof(InstanceData)
range from offsetstate.last_item_index * sizeof(InstanceData)
, but array buffer size is equal todata.max_instances_per_buffer * sizeof(InstanceData)
, smaller than length + offset, so the glMapBufferRange failed and returned null instead, and thus caused the crash.