Fix scaling last bone length with negative scales #81048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagola92
force-pushed
the
fix_last_bone2d_scale
branch
from
1e834e6 to
9c6b2ec
Compare
|
@TokageItLab does this look ok? |
thiagola92
force-pushed
the
fix_last_bone2d_scale
branch
from
9c6b2ec to
d3ae624
Compare
akien-mga
added
the
cherrypick:4.2
thiagola92
commented
Dec 14, 2023
| @@ -325,7 +325,7 @@ bool Bone2D::_editor_get_bone_shape(Vector<Vector2> *p_shape, Vector<Vector2> *p | |||
| rel = rel.rotated(-get_global_rotation()); // Undo Bone2D node's rotation so its drawn correctly regardless of the node's rotation | |||
| } else { | |||
| real_t angle_to_use = get_rotation() + bone_angle; | |||
| rel = Vector2(cos(angle_to_use), sin(angle_to_use)) * (length * MIN(get_global_scale().x, get_global_scale().y)); | |||
| rel = Vector2(cos(angle_to_use), sin(angle_to_use)) * length * get_global_scale().abs(); | |||
There was a problem hiding this comment.
This PR is attempting to give scale to length and could probably be solved by changing how length is calculated: #83397 (comment)
(just an observation, no change should be made in this PR)
TokageItLab
requested changes
Jan 9, 2024
There was a problem hiding this comment.
I also found a more fundamental problem with the bone direction calculation. When the parent has Skew, the bone direction does not take it into account, so everything gets messed up, but this has nothing to do with this PR. Although I think it should be fixed somewhere else.
|
Superseded by #91731. Thanks for the contribution! |
akien-mga
added
archived
and removed
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #80643
Change to use absolute value.
EDIT:
I was trying to maintain the logic "use the lower value to define the length of the last bone", but I don't think this the right way.
The user always want to see how much the bone is scaled in any direction, so why use the lower value?
No change to scale:
Current behaviour when scaling X to 3:
Propose change:
This also helps with #76087, in this issue we can see that saving calls this functions to redraw bones. Current behavior:
Note: Changing this would only help with the last bone.