Fix a editor restart crash when custom_display_scale is set to NAN #81050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjtxietian
force-pushed
the
fix-custom_display_scale_nan_crash
branch
from
7957e69 to
e8378f2
Compare
bruvzg
reviewed
Aug 28, 2023
jsjtxietian
force-pushed
the
fix-custom_display_scale_nan_crash
branch
from
e8378f2 to
aa93f77
Compare
Add some protection in EditorScale::set_scale
jsjtxietian
force-pushed
the
fix-custom_display_scale_nan_crash
branch
from
aa93f77 to
ce44cd0
Compare
|
This was actually superseded by #81076. Of course, users may still find a way to break it if they are actively trying to, but there is a limit for how far we should protect them from shooting themselves in their feet. 🙃 Thanks for your contribution nevertheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81041. Add some protection in EditorScale::set_scale.
It's better to add some limit when assign the value
interface/editor/custom_display_scalebut it will require more work. But I'm happy to apply your suggestions as well.