-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve MeshDataTool.get_face_vertex()
method description
#81088
Improve MeshDataTool.get_face_vertex()
method description
#81088
Conversation
Would need a c# example as well, @raulsntos? |
Looks great! The final step before merging is to squash all the commits together so that the whole PR only contains 1 big commit with all your changes. We like to merge one commit at a time to keep the git history clean and navigable. If you don't know how to do that, we have a helpful tutorial in the official documentation https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html#the-interactive-rebase |
MeshDataTool.get_face_vertex
method descriptionMeshDataTool.get_face_vertex()
method description
ff78f4b
to
d5548db
Compare
I would also suggest rewording the commit message as we don't use this format usually. The title of this PR is a good match for our usual commit style (you can see other examples in |
d5548db
to
7833a0a
Compare
@akien-mga thanks for this suggestion! |
7833a0a
to
169daea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content looks great! Thank you
Improve MeshDataTool.get_face_vertex() method description and also add an example code. Co-authored-by: Raul Santos <raulsntos@gmail.com>
169daea
to
adb0d0e
Compare
@clayjohn the commit description wasn't looking good so I just adjusted it, sorry for the delay! |
Thanks! |
Cherry-picked for 4.1.3. |
What I did
MeshDataTool.get_face_vertex()
method description by making it more clear about what is the data type that is returned and adding a code example.Closes: #7852 (issue from godot-docs repo)