Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridMap: Ensure the visibility is updated when entering the tree #81106

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

garychia
Copy link
Contributor

Fixes #81000
The visibility of GridMap is not updated when entering the tree.

@garychia garychia requested a review from a team as a code owner August 29, 2023 07:36
@akien-mga akien-mga requested review from Calinou and KoBeWi August 29, 2023 07:39
@akien-mga akien-mga added this to the 4.2 milestone Aug 29, 2023
@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Aug 29, 2023
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward and sensible.

@akien-mga akien-mga merged commit d189634 into godotengine:master Sep 2, 2023
@akien-mga
Copy link
Member

Thanks!

@garychia garychia deleted the gridmap_visibility branch September 2, 2023 12:41
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gridmap shows after reload_current_scene() if hidden in editor
3 participants