[MP] Improve SceneReplicationConfig editor UX + optimizations #81136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faless
force-pushed
the
mp/replication_mode
branch
2 times, most recently
from
d12384e to
6524ded
Compare
Faless
force-pushed
the
mp/replication_mode
branch
from
6524ded to
f51531f
Compare
YuriSizov
reviewed
Aug 30, 2023
Faless
force-pushed
the
mp/replication_mode
branch
from
f51531f to
cfed093
Compare
YuriSizov
reviewed
Aug 30, 2023
YuriSizov
reviewed
Aug 30, 2023
YuriSizov
reviewed
Aug 30, 2023
REPLICATION_MODE_ALWAYS (sync) and REPLICATION_MODE_ON_CHANGE (watch) are now mutually exclusive. Prevent invalid NodePath from being added to the config. Optimize the replication config loading by composing the lists on demand.
YuriSizov
approved these changes
Aug 30, 2023
Faless
force-pushed
the
mp/replication_mode
branch
3 times, most recently
from
bccef21 to
3a7bc74
Compare
Use an option button for the replication mode making sync and watch (now "Always" and "On Change") mutually exclusive.
Faless
force-pushed
the
mp/replication_mode
branch
from
3a7bc74 to
c1c6911
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make "Sync" and "Watch" mutually exclusive by adding an enum (Never/Always/On Change).
Deprecate old methods.
Prevent invalid NodePath from being added to the config.
Optimize the replication config loading by composing the lists on demand.
Fixes #77896