Add project settings for AVAudioSessionCategory on iOS
#81196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgwacker
force-pushed
the
add-audiosession-options
branch
3 times, most recently
from
344a5c6
to
91b92b5
Compare
georgwacker
force-pushed
the
add-audiosession-options
branch
4 times, most recently
from
4a137f3
to
29ea533
Compare
|
Also documentation has to be sorted alphabetically |
georgwacker
force-pushed
the
add-audiosession-options
branch
from
29ea533
to
6d3475f
Compare
bruvzg
reviewed
Sep 1, 2023
georgwacker
force-pushed
the
add-audiosession-options
branch
from
6d3475f
to
dea50f3
Compare
|
I changed the setting to int and created an enum for the comparison, let me know if that is proper or if the enum should reside in the Godot context? I did not find an example in the macos/ios code that uses an enum, so I'm not sure how I would access it. |
georgwacker
force-pushed
the
add-audiosession-options
branch
from
dea50f3
to
9f678ab
Compare
bruvzg
approved these changes
Oct 17, 2023
georgwacker
force-pushed
the
add-audiosession-options
branch
from
9f678ab
to
82d322c
Compare
georgwacker
force-pushed
the
add-audiosession-options
branch
from
82d322c
to
fcc500e
Compare
|
Thanks! |
akien-mga
changed the title
AVAudioSessionCategory on iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds project settings for AVAudioSessionCategory on iOS, related to #50638 (does not fix the error log).
For the setting path I tried to stay consistent with the setting structure in display/window/ios.