Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Expose asinh, acosh and atanh in Mathf #81229

Merged
merged 1 commit into from
Sep 4, 2023
Merged

C#: Expose asinh, acosh and atanh in Mathf #81229

merged 1 commit into from
Sep 4, 2023

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos added this to the 4.2 milestone Sep 1, 2023
@raulsntos raulsntos requested a review from a team as a code owner September 1, 2023 15:30
@raulsntos raulsntos force-pushed the dotnet/arc-hyperbolic branch from 3d3986a to 36b9e47 Compare September 1, 2023 15:30
@AThousandShips
Copy link
Member

Should the documentation comments have the note from the original PR:

Returns the hyperbolic arc (also called inverse)

@raulsntos raulsntos force-pushed the dotnet/arc-hyperbolic branch from 36b9e47 to f900050 Compare September 2, 2023 10:00
@akien-mga akien-mga merged commit 0215d53 into godotengine:master Sep 4, 2023
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/arc-hyperbolic branch September 4, 2023 10:12
jynus added a commit to jynus/godot-docs that referenced this pull request Sep 23, 2023
@jynus
C#: Document new Asinh, Acosh and Atanh functions in Mathf
22f25b6 
Document on the list of C# api differences the newly exposed

* Mathf.Asinh()
* Mathf.Acosh()
* Mathf.Atanh()

Followup to godotengine/godot#81229
@jynus jynus mentioned this pull request Sep 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:dotnet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@raulsntos @AThousandShips @akien-mga