[TextServer] Use locale or first span language to select preferred direction for neutral text.

[bruvzg]

Fixes #81348

[akien-mga]

Actually I need to test a bit, I'm slightly worried that it can lead to unexpected results based on the system locale. E.g. a game meant to be in English / LTR running on an Arabic system, without any special care taken to ensure LTR everywhere. Would this start flipping neutral strings?

[bruvzg]

Actually I need to test a bit, I'm slightly worried that it can lead to unexpected results based on the system locale. E.g. a game meant to be in English / LTR running on an Arabic system, without any special care taken to ensure LTR everywhere. Would this start flipping neutral strings?

It should not, get_tool_locale() should only return one of the locales supported by the app (or editor).

godot/core/string/translation.cpp

Lines 712 to 744 in 0a7f75e

	String TranslationServer::get_tool_locale() {
	#ifdef TOOLS_ENABLED
	if (Engine::get_singleton()->is_editor_hint() || Engine::get_singleton()->is_project_manager_hint()) {
	if (TranslationServer::get_singleton()->get_tool_translation().is_valid()) {
	return tool_translation->get_locale();
	} else {
	return "en";
	}
	} else {
	#else
	{
	#endif
	// Look for best matching loaded translation.
	String best_locale = "en";
	int best_score = 0;
	for (const Ref<Translation> &E : translations) {
	const Ref<Translation> &t = E;
	ERR_FAIL_COND_V(t.is_null(), best_locale);
	String l = t->get_locale();
	int score = compare_locales(locale, l);
	if (score > 0 && score >= best_score) {
	best_locale = l;
	best_score = score;
	if (score == 10) {
	break; // Exact match, skip the rest.
	}
	}
	}
	return best_locale;
	}
	}

[akien-mga]

Thanks!