Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document ScrollContainer signals being emitted for touch events only #81517

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Document ScrollContainer signals being emitted for touch events only #81517

merged 1 commit into from
Sep 11, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 10, 2023

@Calinou Calinou requested a review from a team as a code owner September 10, 2023 16:26
@Calinou Calinou added enhancement documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 10, 2023
@Calinou Calinou added this to the 4.2 milestone Sep 10, 2023
AThousandShips
AThousandShips approved these changes Sep 10, 2023
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit 218a27a into godotengine:master Sep 11, 2023
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the doc-scrollcontainer-signal-touch-only branch September 13, 2023 21:50
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Sep 21, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.2.

@AThousandShips AThousandShips mentioned this pull request Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.2
4 participants
@Calinou @akien-mga @YuriSizov @AThousandShips