Hide the dialog_text property from FileDialog
#81546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
approved these changes
Sep 11, 2023
It's useless in `FileDialog`, because dialogs can have either a text label or a custom layout, and `FileDialog` already has a custom layout.
YuriSizov
force-pushed
the
there-isnt-enough-room-for-two-ways-to-customize-a-dialog-in-this-town-boy
branch
from
51c286b to
d0e2657
Compare
|
Thanks! |
YuriSizov
deleted the
there-isnt-enough-room-for-two-ways-to-customize-a-dialog-in-this-town-boy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useless in
FileDialog, because dialogs can have either a text label or a custom layout, andFileDialogalready has a custom layout. If you use the property, this is what it ends up looking like:So to avoid confusion I propose we just hide it, like we do in other nodes in similar cases.
PS. I'll have to rebase after #81312 due to neighboring changes in the header file.Done.