Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify PackedByteArray.decompress* limitations with external data #81689

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Clarify PackedByteArray.decompress* limitations with external data #81689

merged 1 commit into from
Jan 24, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Sep 15, 2023 •
edited
Loading

Might clarify further that it returns an empty array if it fails, and considering adding error messages to the decompress method to make it more visible to the user.

@AThousandShips AThousandShips added this to the 4.2 milestone Sep 15, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner September 15, 2023 11:19
@AThousandShips AThousandShips changed the title Clarify [PackedByteArray.decompress*] limitations with external data Clarify PackedByteArray.decompress* limitations with external data Sep 15, 2023
@AThousandShips AThousandShips force-pushed the compress_doc branch 2 times, most recently from ac940b3 to 078b24e Compare September 15, 2023 11:23
ryanabx
ryanabx approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@ryanabx ryanabx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have suffered from the lack of clarity on this before. I agree with your suggestion to add a warning to the user, I don't know how often runtime warnings are created but we should consider adding one for this case.

@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 26, 2023
@AThousandShips AThousandShips added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release and removed topic:core labels Oct 26, 2023
@YuriSizov YuriSizov merged commit e8f33a7 into godotengine:master Jan 24, 2024
15 checks passed
@AThousandShips AThousandShips deleted the compress_doc branch January 24, 2024 13:15
@YuriSizov
Copy link
Contributor

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanabx ryanabx ryanabx approved these changes

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @YuriSizov @ryanabx