Make LineEdit secret character easier to change and enter #81724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjtxietian
force-pushed
the
fix-line-edit-secret-char-hard-to-change
branch
from
810fdc5
to
c28be77
Compare
jsjtxietian
force-pushed
the
fix-line-edit-secret-char-hard-to-change
branch
from
c28be77
to
0ccdf1d
Compare
jsjtxietian
force-pushed
the
fix-line-edit-secret-char-hard-to-change
branch
2 times, most recently
from
1fe9590
to
ded395f
Compare
KoBeWi
reviewed
Oct 18, 2023
|
If extra characters are ignored, maybe we should have a configuration warning saying that. |
jsjtxietian
force-pushed
the
fix-line-edit-secret-char-hard-to-change
branch
from
ded395f
to
3e2b08d
Compare
|
By "configuration warning" I mean |
jsjtxietian
force-pushed
the
fix-line-edit-secret-char-hard-to-change
branch
from
3e2b08d
to
e699640
Compare
KoBeWi
reviewed
Oct 19, 2023
|
You need to call |
|
I see. |
jsjtxietian
force-pushed
the
fix-line-edit-secret-char-hard-to-change
branch
from
e699640
to
fbbe379
Compare
KoBeWi
reviewed
Oct 19, 2023
1. Allow values longer than 1 character in the property,
but trim characters after the first one.
2. Allow empty strings, this acts like if a space was used as a secret character,
so that an error isn't printed when you erase all characters in the property.
jsjtxietian
force-pushed
the
fix-line-edit-secret-char-hard-to-change
branch
from
fbbe379
to
6950aab
Compare
KoBeWi
approved these changes
Oct 19, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81681.
About the implementation, we can add another field for displaying the char and so
secret_charactercan only store the result of the above rule or vice versa. But that requires more change, so I decided to change the drawing part, calculate the rightsecret_characterbased on the rule above.