Improve VisibleOnScreen classes' docs #81774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewPurPur
force-pushed
the
improve-visible-on-screen-class-docs
branch
from
7addb06 to
21cf8d3
Compare
Calinou
added
enhancement
documentation
cherrypick:4.1
|
cc @mrjustaguy, as they worked with this class previously. |
mrjustaguy
suggested changes
Sep 17, 2023
MewPurPur
force-pushed
the
improve-visible-on-screen-class-docs
branch
5 times, most recently
from
22815f8 to
dc669a2
Compare
YuriSizov
reviewed
Oct 17, 2023
YuriSizov
reviewed
Oct 17, 2023
YuriSizov
approved these changes
Oct 17, 2023
MewPurPur
force-pushed
the
improve-visible-on-screen-class-docs
branch
from
dc669a2 to
53d0ba2
Compare
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
If we want this in 4.1, it would make sense to create a separate PR that only adds missing descriptions. I'd avoid breaking translations in the fourth patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These docs were super old and had some misleading information, unless I've misunderstood something. Some bad English too. And a few descriptions were missing.
I tested to reaffirm that I'm not getting things wrong, but I'm not a big user of these classes so I might have missed some peculiarity or something.