-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented {project}
placeholder for external dotnet editor
#81847
Implemented {project}
placeholder for external dotnet editor
#81847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to the .NET module! The changes look good, they're pretty much the same changes requested by @RedworkDE in #74517 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me already. Since you are a new contributor, make sure to read CONTRIBUTING.md and the contributing documentation if you haven't already.
You'll need to squash the commits before this PR can be merged. The contributing documentation contains information about squashing in case you need it.
Feel free to reach out in the development chat if you need help.
79cd98e
to
d756c26
Compare
Implements the {project} placeholder, available when setting an external editor in the project settings, via Editor > Editor Settings > Text Editor > External for the c# external editor, under Editor > Editor Settings > Dotnet > Editor, This allows passing the project folder as a command line argument when using a custom external editor that isn't one of the available options. Fixes godotengine#81845
d756c26
to
c01a478
Compare
Thanks! And congrats for your first merged Godot contribution 🎉 |
{project}
placeholder for external dotnet editor
Cherry-picked for 4.1.4. |
This PR fixes #81845 , by mimicking the implementation at
godot/editor/plugins/script_editor_plugin.cpp
Lines 2291 to 2316 in 4df80b0
As the function
ProjectSettings::get_singleton()->get_resource_path()
isn't exposed in the godot API, this solution instead makes use of ProjectSettings.GlobalizePath("res://"), which, on editor builds, returnsProjectSettings.resource_path + "/"
, according to its implementation atgodot/core/config/project_settings.cpp
Lines 257 to 272 in 4df80b0