Web: Fix version check for missing scalbnf LTO workaround #81869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check needs to happen after we set `env["CXX"]`. Follow-up to godotengine#81340.
akien-mga
added
bug
platform:web
topic:buildsystem
cherrypick:3.x
YuriSizov
approved these changes
Sep 18, 2023
|
Cherry-picked for 4.1.2. |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.5.3. |
akien-mga
removed
the
cherrypick:3.5
MarioLiebisch
added a commit
to MarioLiebisch/godot
that referenced
this pull request
Sep 25, 2023
This fixes multiple issues/inconsistencies around `get_compiler_version()`: * With no shell allocated, launching the compiler could fail even with proper paths being set. * The return value was described as "an array of version numbers as ints", but the function actually returned a `Dictionary` (or `None`). * Not all calls were properly handling a `None` return value in case of errors. On Windows this broke compiling for me since godotengine#81869 with default settings. * Some calls defined inconsistent defaults/fallbacks (`0` or `-1`).
mandryskowski
pushed a commit
to mandryskowski/godot
that referenced
this pull request
Oct 11, 2023
This fixes multiple issues/inconsistencies around `get_compiler_version()`: * With no shell allocated, launching the compiler could fail even with proper paths being set. * The return value was described as "an array of version numbers as ints", but the function actually returned a `Dictionary` (or `None`). * Not all calls were properly handling a `None` return value in case of errors. On Windows this broke compiling for me since godotengine#81869 with default settings. * Some calls defined inconsistent defaults/fallbacks (`0` or `-1`).
YuriSizov
pushed a commit
to YuriSizov/godot
that referenced
this pull request
Oct 24, 2023
This fixes multiple issues/inconsistencies around `get_compiler_version()`: * With no shell allocated, launching the compiler could fail even with proper paths being set. * The return value was described as "an array of version numbers as ints", but the function actually returned a `Dictionary` (or `None`). * Not all calls were properly handling a `None` return value in case of errors. On Windows this broke compiling for me since godotengine#81869 with default settings. * Some calls defined inconsistent defaults/fallbacks (`0` or `-1`). (cherry picked from commit 426e18f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check needs to happen after we set
env["CXX"]. Follow-up to #81340.