Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix zero scale in particle shader #81902

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

lawnjelly
Copy link
Member

Fixes the lower bounding of scale when given zero input.

The previous bug was due to sign returning 0 with 0.0 input, rather than 1.

Fixes #80863

Notes

@lawnjelly lawnjelly added this to the 3.6 milestone Sep 19, 2023
@lawnjelly lawnjelly changed the title Fix zero scale in particle shader [3.x] Fix zero scale in particle shader Sep 19, 2023
Fixes the lower bounding of scale when given zero input.

The previous bug was due to `sign` returning 0 with 0.0 input, rather than 1.
@lawnjelly lawnjelly force-pushed the fix_particle_zero_scale branch from e41e59b to 1f4a6e4 Compare September 19, 2023 07:31
@akien-mga akien-mga merged commit 1d7a417 into godotengine:3.x Sep 19, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants