Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable bounding box shadows for advanced scene importer #82190

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Disable bounding box shadows for advanced scene importer #82190

merged 1 commit into from
Sep 24, 2023

Conversation

BlueCube3310
Copy link
Contributor

Fixes #82180

Sets the bounding box's shadow casting mode to off.

@BlueCube3310 BlueCube3310 requested a review from a team as a code owner September 23, 2023 13:24
@AThousandShips AThousandShips added this to the 4.2 milestone Sep 23, 2023
fire
fire approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to test, but disabling the wireframe shadows is good. shadows would be a good change.

@akien-mga akien-mga merged commit 9e011c3 into godotengine:master Sep 24, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@BlueCube3310 BlueCube3310 deleted the aabb-import-shadows-disable branch April 25, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:import topic:rendering
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Bounding box wires cast a shadow in the advanced 3d model import settings
4 participants
@BlueCube3310 @akien-mga @fire @AThousandShips