Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 3D editor gizmos and debug shapes ignore fog #82413

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 26, 2023

This makes them easier to see in their intended colors in scenes with fog. This also fixes issues with gizmo colors changing if viewed behind fog with Sun Scatter enabled.

Testing project: test_fog_3d_gizmos.zip

Preview

Before After
Screenshot_20230927_003915 Screenshot_20230927_005449

This makes them easier to see in their intended colors in scenes with fog.
@JekSun97
Copy link

Looks logical and convenient

@atirut-w
Copy link
Contributor

Is it possible for them to ignore environment settings entirely?

@Calinou
Copy link
Member Author

Calinou commented Sep 27, 2023

Is it possible for them to ignore environment settings entirely?

Not without large changes (especially if you want to preserve depth awareness), as it would require rendering 3D gizmos on a separate pass.

@atirut-w
Copy link
Contributor

Bummer. This is something, at least.

Copy link
Contributor

@smix8 smix8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation looks fine.

@akien-mga akien-mga merged commit 3228f73 into godotengine:master Sep 27, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants