-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDScript: Improve highlighting of types #82516
Conversation
This also resolves #44922 🙂 |
#82326 is still relevant and not superseded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. I'm surprised to see void
highlighted as a type - it both makes and doesn't make sense to me as a user. Given the context it always pops up in, I think it's better this way.
Good lord, thank you for making the numeric types green, it was bothering me for so long. |
Given the way highlighter works, the only solution I see is to highlight all |
I think get and set are not keywords because they can be method names. |
5052b20
to
e750c59
Compare
Thanks! |
for
loop variable type.void
,bool
,int
, andfloat
as types, not as keywords. This is especially good when there is another keyword next to the type (likeif a is int or a is float
).Variant.Type
).Variant
.