Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an error in Vector3.BezierDerivative in mono module #82664

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

hackerzhuli
Copy link
Contributor

Fixed a bug in Vector3.BezierDerivative in mono module. In Vector3.BezierDerivative, the last line does not look right, end.Y is used instead of end.Z, from what I understand, this is probably a bug.

@hackerzhuli hackerzhuli requested a review from a team as a code owner October 2, 2023 07:10
@Chaosus Chaosus added this to the 4.2 milestone Oct 2, 2023
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was a typo. Thank you so much for fixing it!

@raulsntos raulsntos added cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 2, 2023
@akien-mga akien-mga changed the title Fixed an error in Vector3.BezierDerivative in mono module Fixed an error in Vector3.BezierDerivative in mono module Oct 2, 2023
@akien-mga akien-mga merged commit 6bebd9c into godotengine:master Oct 2, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@hackerzhuli
Copy link
Contributor Author

Thank you guys for merging. Happy to contribute.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants