Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking the visibility condition of selected file in the Godot editor's dock #82806

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Fix checking the visibility condition of selected file in the Godot editor's dock #82806

merged 1 commit into from
Oct 27, 2023

Conversation

Vilcrow
Copy link
Contributor

@Vilcrow Vilcrow commented Oct 4, 2023 •
edited
Loading

Fixes #80937.

@Vilcrow Vilcrow requested a review from a team as a code owner October 4, 2023 18:15
@KoBeWi KoBeWi added this to the 4.2 milestone Oct 4, 2023
KoBeWi
KoBeWi previously approved these changes Oct 23, 2023
View reviewed changes
@KoBeWi
Copy link
Member

KoBeWi commented Oct 23, 2023

The line was added in #28770. Removing it reintroduces #26041
Instead of outright removing it, add a check if the path is directory.

@akien-mga akien-mga merged commit 8919d1c into godotengine:master Oct 27, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Vilcrow Vilcrow deleted the fix-ensure-selected-visible branch October 28, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

double clicking to preview a resource scrolls the filesystem view when in split mode
3 participants
@Vilcrow @KoBeWi @akien-mga