Only perform modelview transform on tangent and binormal when vertex shader is in local space #82892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix a reported issue. Most likely because world_vertex_coords is totally unusable right now (until #82886 is merged).
In master when tangents are used, the tangents and binormals go through a model-to-view space transformation regardless of what space they are in. Therefore, when using skip_vertex_transform, or world_vertex_coords the tangent and binormal will end up in a completely wrong coordinate space and will look totally wrong.
This appears to have come from a typo in the early days of rewriting the renderer for Godot 4.0 8cee770#diff-ab6440873ccc60605b6c0f0bbc3e3bc2d94b7c8238824321a579fb868aebf5cb