Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Report diagnostic for Node exports in a type that doesn't derive from Node #82918

Merged
merged 1 commit into from
Oct 27, 2023
Merged

C#: Report diagnostic for Node exports in a type that doesn't derive from Node #82918

merged 1 commit into from
Oct 27, 2023

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos commented Oct 6, 2023 •
edited
Loading

@raulsntos raulsntos added this to the 4.2 milestone Oct 6, 2023
@raulsntos raulsntos requested a review from a team as a code owner October 6, 2023 17:04
@YuriSizov
Copy link
Contributor

@RedworkDE Would you mind giving this a review?

@akien-mga akien-mga modified the milestones: 4.2, 4.3 Oct 26, 2023
RedworkDE
RedworkDE approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@RedworkDE RedworkDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only note that I have is that we kinda have GodotClasses to store type name constants like "Godot.Node" but that class doesn't seem to be used very consistently and currently doesn't have an entry for Node.

@akien-mga akien-mga modified the milestones: 4.3, 4.2 Oct 26, 2023
@akien-mga akien-mga merged commit bf41c6b into godotengine:master Oct 27, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/only-node-can-export-node branch October 27, 2023 11:44
@raulsntos raulsntos mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedworkDE RedworkDE RedworkDE approved these changes

Assignees
No one assigned
Labels
enhancement topic:dotnet
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@raulsntos @YuriSizov @akien-mga @RedworkDE