Don't apply frame delay project setting to the editor #82929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:editor
cherrypick:4.1
Calinou
force-pushed
the
projectsettings-frame-delay-no-editor
branch
from
3a3dd84 to
3f82bba
Compare
Calinou
force-pushed
the
projectsettings-frame-delay-no-editor
branch
from
3f82bba to
5553ec8
Compare
|
There were times I've used this in the past, to avoid burning through my laptop battery. I've replaced that with an hardcoded limit in my GPU setting when the window is unfocused. If the editor itself is capped to the monitor's refresh rate I suppose this is fine, then... |
It is, as V-Sync applies to the editor if it's enabled in the project settings (#48364 decouples the setting as well). |
YuriSizov
reviewed
Nov 10, 2023
YuriSizov
approved these changes
Nov 10, 2023
This appears to already be the case for the Max FPS project setting.
akien-mga
force-pushed
the
projectsettings-frame-delay-no-editor
branch
from
5553ec8 to
a635562
Compare
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to already be the case for the Max FPS project setting.
I've tested manual override in a running project via project setting or CLI argument and it still works as expected.
--frame-delayalso still works on the editor itself, if you really want to use it.