Fix rename warning dialog #82941
Closed
Fix rename warning dialog #82941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When renaming from `FileSystemList`, the focus changes to the `LineEdit`. Don't check if the `FileSystemList` has focus, since it doesn't have focus.
|
My PR #82075 includes this fix. It also fixes a crash that occurs in single window mode. |
|
Closing in favor of preexisting duplicate #82075. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When renaming files from
FileSystemList, the focus changes to theLineEdit. Don't check if theFileSystemListhas focus, since it doesn't have focus.This ensures to return always from the function when a rename error happens. Currently there is an execution path, that allows staying in the function, which results in the situation, that the warning-message-popup is opened a second time, that causes the error message in the console.
resolve part of #82543