Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove excessive warnings when calling one static method from another in autoload #83008

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove excessive warnings when calling one static method from another in autoload #83008

wants to merge 4 commits into from
+8 −1

Conversation

k0T0z
Copy link
Contributor

@k0T0z k0T0z commented Oct 8, 2023

Fixes #82999.

@k0T0z
improving static_called_on_instance.gd based on godotengine#82999
86cd191 
Signed-off-by: Saif Kandil <74428638+k0T0z@users.noreply.github.com>
@k0T0z k0T0z requested a review from a team as a code owner October 8, 2023 17:00
@k0T0z k0T0z marked this pull request as draft October 8, 2023 17:01
@dalexeev dalexeev added this to the 4.x milestone Oct 8, 2023
@dalexeev
Copy link
Member

dalexeev commented Oct 8, 2023

There are no fixes in this PR at the moment, just changes to the tests.

@k0T0z
Copy link
Contributor Author

k0T0z commented Oct 8, 2023

@dalexeev That's why I made it draft for now, I am working on a fix at the moment. Is this prohibited here? I mean submitting a draft PR before providing a fix?

@dalexeev
Copy link
Member

dalexeev commented Oct 8, 2023

Is this prohibited here?

No, it's not prohibited, I just warned you in case of a mistake or confusion.

@k0T0z
improving test
aef45e5 
Signed-off-by: Saif Kandil <74428638+k0T0z@users.noreply.github.com>
@k0T0z k0T0z mentioned this pull request Oct 9, 2023
Merged
@k0T0z
fixing wrong warning when when using Globals with static functions
e2e0b2e 
Signed-off-by: Saif Kandil <74428638+k0T0z@users.noreply.github.com>
@k0T0z k0T0z marked this pull request as ready for review October 15, 2023 10:54
@Chaosus
Copy link
Member

Chaosus commented Oct 17, 2023

bool is_self = false, is_global = false;

Is not a correct syntax, use separate lines.

@YuriSizov YuriSizov changed the title Fix unnecessary warnings emision when calling a static method from a static method in autoload Remove excessive warnings when calling a static method from another static method in autoload Oct 17, 2023
@YuriSizov YuriSizov changed the title Remove excessive warnings when calling a static method from another static method in autoload Remove excessive warnings when calling one static method from another in autoload Oct 17, 2023
@k0T0z
fix checking singleton condition
8d20b76 
Signed-off-by: Saif Kandil <74428638+k0T0z@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexeev dalexeev dalexeev left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug topic:gdscript
Projects
None yet
Milestone
4.x
Development

Successfully merging this pull request may close these issues.

Calling a static method from a static method in autoload, emits unnecessary warnings
3 participants
@k0T0z @dalexeev @Chaosus