Fix EditorFileSystemDirectory::get_file_deps() may return wrong result

[Rindbee]

Limit the max split to 8 to get complete deps.

deps caches the return value of ResourceLoader::get_dependencies(), which is also separated by "::" (eg uid://dnl1wt40gvcuu::::res://icon.svg).
"::" is quite popular as a splitter.

Reference: Code for storing information

godot/editor/editor_file_system.cpp

Lines 1326 to 1335 in 6b727eb

	String s = p_dir->files[i]->file + "::" + type + "::" + itos(p_dir->files[i]->uid) + "::" + itos(p_dir->files[i]->modified_time) + "::" + itos(p_dir->files[i]->import_modified_time) + "::" + itos(p_dir->files[i]->import_valid) + "::" + p_dir->files[i]->import_group_file + "::" + p_dir->files[i]->script_class_name + "<>" + p_dir->files[i]->script_class_extends + "<>" + p_dir->files[i]->script_class_icon_path;
	s += "::";
	for (int j = 0; j < p_dir->files[i]->deps.size(); j++) {
	if (j > 0) {
	s += "<>";
	}
	s += p_dir->files[i]->deps[j];
	}
	p_file->store_line(s);

[KoBeWi]

I'm wondering about the code below:

godot/editor/editor_file_system.cpp

Lines 287 to 294 in e8d57af

	String deps = split[8].strip_edges();
	if (deps.length()) {
	Vector<String> dp = deps.split("<>");
	for (int i = 0; i < dp.size(); i++) {
	String path = dp[i];
	fc.deps.push_back(path);
	}
	}

It uses the last split and splits it using <> separator. Which is weird, because the dependencies are written with :: 🤔Also the :: has caused an error in the past (#78242).
Not sure what does this code do, it seems it wasn't working correctly for quite some time.

In any case, while your change is correct, I think the splitting code I linked is wrong. It should either use ::, or better, the deps should be written using <>. Though changing how they are serialized might break something, idk. Probably not that important, given it wasn't correct (unless I'm missing something).

[Rindbee]

godot/editor/editor_file_system.cpp

Line 936 in e8d57af

fi->deps = _get_dependencies(path);

godot/editor/editor_file_system.cpp

Lines 1520 to 1525 in e8d57af

	ResourceLoader::get_dependencies(p_path, &deps);
	Vector<String> ret;
	for (const String &E : deps) {
	ret.push_back(E);
	}

godot/doc/classes/ResourceLoader.xml

Lines 37 to 43 in e8d57af

	Returns the dependencies for the resource at the given [param path].
	[b]Note:[/b] The dependencies are returned with slices separated by [code]::[/code]. You can use [method String.get_slice] to get their components.
	[codeblock]
	for dep in ResourceLoader.get_dependencies(path):
	print(dep.get_slice("::", 0)) # Prints UID.
	print(dep.get_slice("::", 2)) # Prints path.
	[/codeblock]

godot/scene/resources/resource_format_text.cpp

Lines 858 to 882 in e8d57af

	if (next_tag.fields.has("uid")) {
	// If uid exists, return uid in text format, not the path.
	String uidt = next_tag.fields["uid"];
	ResourceUID::ID uid = ResourceUID::get_singleton()->text_to_id(uidt);
	if (uid != ResourceUID::INVALID_ID) {
	fallback_path = path; // Used by Dependency Editor, in case uid path fails.
	path = ResourceUID::get_singleton()->id_to_text(uid);
	using_uid = true;
	}
	}
	if (!using_uid && !path.contains("://") && path.is_relative_path()) {
	// Path is relative to file being loaded, so convert to a resource path.
	path = ProjectSettings::get_singleton()->localize_path(local_path.get_base_dir().path_join(path));
	}
	if (p_add_types) {
	path += "::" + type;
	}
	if (!fallback_path.is_empty()) {
	if (!p_add_types) {
	path += "::"; // Ensure that path comes third, even if there is no type.
	}
	path += "::" + fallback_path;
	}

The format of a single dep is UID::TYPE::FILEPATH (TYPE usually does not exist). And if it is a script, the format is FILEPATH (personally, I feel that for non-scripts, it would be better if its format is FILEPATH::TYPE::UID, and I'm curious what dep.get_slice("::", 1) is.)

Eg. the dependencies of c.tscn include res://a.tscn, res://b.tscn, res://c.gd, res://Label2.gd.

These single dep:

uid://b0rtjjhymwmhd::::res://a.tscn
uid://cdw0p6dbf3p36::::res://b.tscn
res://c.gd
res://Label2.gd

The deps will be recorded as:

uid://b0rtjjhymwmhd::::res://a.tscn<>uid://cdw0p6dbf3p36::::res://b.tscn<>res://c.gd<>res://Label2.gd

A correct and complete record should be:

c.tscn::PackedScene::4055944345688729969::1698188374::0::1::::<><>::uid://b0rtjjhymwmhd::::res://a.tscn<>uid://cdw0p6dbf3p36::::res://b.tscn<>res://c.gd<>res://Label2.gd

split would be the opposite operation.

[akien-mga]

Thanks!