Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Manager: Open project when "Enter" is pressed when the search box is focused #83210

Merged

Conversation

alfredbaudisch
Copy link
Contributor

@alfredbaudisch alfredbaudisch commented Oct 12, 2023

In the project manager, when the Search Box is focused, the Key::Enter event is not being handled by ProjectManager::shortcut_input. So added a dedicated handler for the search box with the signal gui_input. Now when Enter is pressed, the highlighted project is opened.

Fixes and closes #73768.

@akien-mga
Copy link
Member

Makes sense. But LineEdit has a text_submitted signal exactly for this, you don't need to reimplement it via _gui_input.

@alfredbaudisch
Copy link
Contributor Author

Makes sense. But LineEdit has a text_submitted signal exactly for this, you don't need to reimplement it via _gui_input.

Done 👍

@akien-mga akien-mga changed the title Project Manager: open project when "Enter" is pressed when the search box is focused Project Manager: Open project when "Enter" is pressed when the search box is focused Oct 13, 2023
@akien-mga akien-mga merged commit f9c0c60 into godotengine:master Oct 13, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@alfredbaudisch alfredbaudisch deleted the manager-search-box-enter branch October 13, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project List's "Filter Projects" doesn't load first project on Enter key, but "Sort" field does
2 participants