Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable port name auto translation in Visual Shader editor #83233

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

timothyqiu
Copy link
Member

Currently, visual shader port names are not extracted for translation. Some of the port names got translated if the name is used in other places.

I think we need to add a separate translation switch for the visual shader editor. Users should be able to turn translation off separately just like Inspector's property name switch. But since we're in feature freeze, it's better to simply disable auto translation for 4.2 and implement that in later versions.

@timothyqiu timothyqiu added this to the 4.2 milestone Oct 13, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner October 13, 2023 03:00
@akien-mga akien-mga merged commit f6ff415 into godotengine:master Oct 13, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants