Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing editor singletons when dumping extension api #83239

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix missing editor singletons when dumping extension api #83239

merged 1 commit into from
Oct 13, 2023

Conversation

Daylily-Zeleen
Copy link
Contributor

Fix missing editor singletons (EditorInterface) when dumping extension api after #80962.

@Daylily-Zeleen Daylily-Zeleen requested a review from a team as a code owner October 13, 2023 06:30
@akien-mga akien-mga changed the title Fixs missing editor singletons when dumping extension api Fix missing editor singletons when dumping extension api Oct 13, 2023
akien-mga
akien-mga reviewed Oct 13, 2023
View reviewed changes
main/main.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga requested a review from YuriSizov October 13, 2023 06:35
@akien-mga akien-mga added this to the 4.2 milestone Oct 13, 2023
@Daylily-Zeleen Daylily-Zeleen force-pushed the Fixs-missing-editor-singletons-when-dump-extension-api branch from c3c8bd0 to fee3b85 Compare October 13, 2023 06:37
@AThousandShips
Copy link
Member

Should this be added to the validation case as well?

@dsnopek
Copy link
Contributor

dsnopek commented Oct 13, 2023

Should this be added to the validation case as well?

I suspect the existing validation would have caught it if the EditorInterface singleton was in the extension_api.json from 4.1, but since it was added in master together with the bug described here that excludes editor singletons, it went unnoticed. I'm not sure how we could fix this :-/

dsnopek
dsnopek approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me!

I generated extension_api.json with master and with this PR and diffed them. The only changes I saw were the addition of the missing EditorInterface singleton, and a bunch of editor classes switch from is_instantiable being false to being true. That 2nd change isn't related to the goals of this PR, but since GDExtensions can be used in the editor to make editor plugins, I think it's correct.

@akien-mga akien-mga merged commit 4fd0cfa into godotengine:master Oct 13, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Daylily-Zeleen Daylily-Zeleen deleted the Fixs-missing-editor-singletons-when-dump-extension-api branch October 14, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@dsnopek dsnopek dsnopek approved these changes

@YuriSizov YuriSizov Awaiting requested review from YuriSizov

Assignees
No one assigned
Labels
bug topic:gdextension
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Daylily-Zeleen @AThousandShips @dsnopek @akien-mga