Fix saving wrong edited scene state when switching scene tabs

[Rindbee]

When creating a new scene, the scene tab will actually switch to the newly created one. Also worth noting that switching scene tabs saves state (by save_edited_scene_state).

When trying New Scene again, the previously empty scene tab will be removed.

So the correct logic is: switch the tab save state first, and then remove the previous empty scene tab. To prevent current_edited_scene from being incorrect when saving state.

Fix #83213.

[KoBeWi]

It doesn't seem to fix the linked issue, the scene tree is still getting empty.

[Rindbee]

It doesn't seem to fix the linked issue, the scene tree is still getting empty.

Is it the same way to reproduce?

0.mp4

[KoBeWi]

I'm getting different results in the first case 🤔

godot.windows.editor.dev.x86_64_rNIjV7CZGH.mp4

EDIT:
Ok, it's still broken when you have a single open scene. It works if there is more.

[Rindbee]

Ok, it's still broken when you have a single open scene. It works if there is more.

I still can't reproduce it, maybe due to some non-default editor settings? (I deleted the config, cache and data directories)

1.mp4

[KoBeWi]

I tried in a fresh project in self-contained mode and still get the bug.
EDIT:
No I tested wrongly. I don't get it in a new project. Not sure what causes it my old test project.
EDIT2:
It's not even project-specific ;_; I get it in a one scene, but only initially. After closing and reopening it, the issue doesn't appear again.

[KoBeWi]

Ok I think I got the steps more or less:

• open a project (can be a new project)
• make sure there is only one opened scene and there is no selected node
  • if any of the above is not true, close extra scenes, unselect everything, save and restart
• the bug should now occur when you press Ctrl+N twice

[Rindbee]

It seems that when _load_open_scenes_from_config(), the newly added scenes are not tracked in editor_history.

[YuriSizov]

Seems like a regression from #80517 then? So my main concern is whether this introduces some excessive calls again. editor_history.add_object doesn't look particularly excessive, and I guess it makes sense that we need to "initialize" the history.

My question would be whether we need to do it to every scene, or just the last one that becomes active.

[Rindbee]

My question would be whether we need to do it to every scene, or just the last one that becomes active.

We need to do it to every scene, #83251 (comment) can be reproduced in all open scenes (as long as no nodes are selected).

[YuriSizov]

I see. So something else expects every open scene to be in the history, even if the user never navigated to them. I think it's worth adding a comment to the else clause to explain that.

[akien-mga]

Thanks!