Don't try updating wrong NodePaths in resources

[KoBeWi]

Fixes #83209

[tom95]

Thanks a lot @KoBeWi!

The one error is indeed fixed, I just verified as well.

The error with renaming nodes used in an AnimationPlayer persists. As I understand it, it occurs because the AnimationPlayer handles its tracks specially (it is the only Resource that already supported renaming nested NodePaths, controlled via the autorename_animation_tracks setting). Consequently, when first encountering the AnimationPlayer, the special-cased code performs the rename, and then we descend into the AnimationPlayer object and try to perform the rename once again, thus erroring. A suggested fix that I verified fixed the other scenario, too, is to add this check:

diff --git a/editor/scene_tree_dock.cpp b/editor/scene_tree_dock.cpp
index a38487635f..81805a45d2 100644
--- a/editor/scene_tree_dock.cpp
+++ b/editor/scene_tree_dock.cpp
@@ -1689,6 +1689,10 @@ bool SceneTreeDock::_check_node_path_recursive(Node *p_root_node, Variant &r_var
                                break;
                        }
 
+                       if (Object::cast_to<Animation>(r_variant)) {
+                               break;
+                       }
+
                        List<PropertyInfo> properties;
                        resource->get_property_list(&properties);

...such that we never descend into Animation resources.

[KoBeWi]

I can't reproduce the renaming error. The track gets correctly updated too.

[tom95]

@KoBeWi yep you're right. I must have mixed up branches. Everything is working perfectly with your change.

Sorry for the noise and thanks again for the swift fix :)

[akien-mga]

Thanks!

[eviltrout]

Thanks so much this bug was really slowing me down! I can confirm it works for me too.