-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider children Control nodes for mouse-enter/exit notifications #83276
Conversation
5b2a6c2
to
379ad4b
Compare
Since its a draft I wasn't sure if its ready to be tested or feedback, but it has the needs testing label, so: Moving mouse from child to parent sends the mouse enter and mouse enter self notification to the parent, when it should only send the mouse enter self. Mouse Filters aren't respected. |
Thanks for testing and the valuable feedback, I appreciate it. This is still a draft, because it has some bugs. I will mark it ready for review, when I have addressed the bugs. |
f5a6680
to
9a95c20
Compare
I have redone the PR and updated my initial naive approach with a more robust method that stores in addition to I have also tested the MRP in the linked issue and also verified, that all tests pass. |
It looks like mouse filters are completely ignored. |
I put my take on this here if you want to check it out: kitbdev@df975d8 |
IGNORE seems to work correctly, STOP and PASS do the same though.
Can't reproduce, the node correctly receives mouse exit when hidden. If shown under cursor, the entered notification is not received until mouse movement, but I assume this is expected for performance reasons. |
9a95c20
to
d4098cc
Compare
`NOTIFICATION_MOUSE_ENTER` and `NOTIFICATION_MOUSE_EXIT` now includes the areas of children control nodes. In order to check if a Control node itself was entered/exited, the newly introduced `NOTIFICATION_MOUSE_ENTER_SELF` and `NOTIFICATION_MOUSE_EXIT_SELF` can be used.
d4098cc
to
aa97a0f
Compare
Just checking because I added some comments to various, seemingly-related but already-closed bugs (#17326), but would this solve an issue where I'm trying to drag-and-drop a control into a subviewport on top of another control in said SVP? Seems like it should, but I'm not as familiar with this exact part of the codebase. |
@WolfgangSenff Dragging into different SubViewports is currently not supported. #67531 intends to establish Drag&Drop support for differnet SubViewports. This PR should not have any influence on Drag&Drop. |
Superseded by #84547. |
NOTIFICATION_MOUSE_ENTER
andNOTIFICATION_MOUSE_EXIT
and the according signals now includes the areas of children control nodes.In order to check if a Control node itself was entered/exited, the newly introduced
NOTIFICATION_MOUSE_ENTER_SELF
andNOTIFICATION_MOUSE_EXIT_SELF
can be used.resolve #81909
resolve #82530
regression from #67791
supersedes #82182