Fix creating and updating plugin with dot in folder name #83329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
YuriSizov
added
the
cherrypick:4.2
KoBeWi
approved these changes
Dec 12, 2023
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
detomon
deleted the
fix-creating-and-updating-plugin-with-dot-in-folder-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem when creating a plugin with a dot in the name from the project settings or updating an existing plugin with a dot in the folder name will fail.
Test project: plugin_config_dialog.zip
At the moment, when creating a plugin with a dot in the name and leaving "Script Name" empty, creating the initial plugin script fails as it doesn't add the correct extension.
Also, when a plugin folder is added via file system which contains a dot, information for that plugin cannot be be updated in the project settings as it won’t use the correct plugin folder name. Updating the author, for example, will silently fail.