Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FindReplaceBar focus problems #83335

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix FindReplaceBar focus problems #83335

merged 1 commit into from
Oct 16, 2023
+14 −4

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 14, 2023

After #81128 and then #82914 the _unhandled_input in FindReplaceBar did not work correctly when it was focused.

Fixes #83303

@KoBeWi KoBeWi added this to the 4.2 milestone Oct 14, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner October 14, 2023 14:17
SaracenOne
SaracenOne requested changes Oct 16, 2023
View reviewed changes
editor/code_editor.cpp Outdated Show resolved Hide resolved
SaracenOne
SaracenOne approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit 391897b into godotengine:master Oct 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the focusing_search_power branch October 16, 2023 13:13
@akien-mga akien-mga mentioned this pull request Oct 16, 2023
Closed
@Maran23 Maran23 mentioned this pull request Jan 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Pressing ESC from code search should give focus to the code editor
3 participants
@KoBeWi @akien-mga @SaracenOne