Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Fix converting default Callables to native #83357

Merged
merged 1 commit into from
Nov 10, 2023
Merged

C#: Fix converting default Callables to native #83357

merged 1 commit into from
Nov 10, 2023

Conversation

raulsntos
Copy link
Member

When marshaling Callables, we need to check if the Target property is null. For a "null" or default Callable, the target will be null.

@raulsntos raulsntos added this to the 4.2 milestone Oct 15, 2023
@raulsntos raulsntos requested a review from a team as a code owner October 15, 2023 00:08
@raulsntos raulsntos mentioned this pull request Oct 15, 2023
Closed
akien-mga
akien-mga approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@akien-mga akien-mga merged commit 313bffc into godotengine:master Nov 10, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/ConvertCallableToNative(default) branch November 11, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:dotnet
Projects
None yet
Milestone
4.2
2 participants
@raulsntos @akien-mga