Fix screen center position returned for rotated Camera2D #83427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
approved these changes
Oct 16, 2023
|
Thanks! |
|
You're a hero kleonc, that was fast. Thanks! |
kleonc
added
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44358 (needs a cherry-pick for 3.x) and #83372 which was is a duplicate.
MRP from #83372 (a little tweaked):
with added camera animation + drag enabled
(aka target_position != screen_center)
Basically within the Camera2D calculations the position ("top right" corner) of the screen rect is calculated taking the rotation into account but the screen rect itself is considered in an unrotated space. Simpler to visualize, the red rect (the green rect is what camera would actually show):
Note this PR fixes only the returned screen center position. The incorrectly calculated screen rect (red bounds) is still what is taken into account e.g. when limiting position with
limit_smoothed == falseandposition_smoothing_enabled == false(orange lines = camera limits):Wanted to keep this PR super simple as there are many other strange/suspicious things in the Camera2D logic (see #63773). It's kinda domino-like. 🙃