Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Bindings generator langword check #83504

Merged
merged 1 commit into from
Mar 4, 2024
Merged

C#: Bindings generator langword check #83504

merged 1 commit into from
Mar 4, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Oct 17, 2023

Extracted from #79475

  • Converts certain [code] phrases as C# keywords, changing their wrapping from <c>code</c> to <see langword="code"/>.
  • As many cases are GDScript-specific, this doesn't check against all C# keywords; instead, it pulls from langword_check — a predefined collection of safe strings (currently: true, false, null).

@Repiteo Repiteo requested a review from a team as a code owner October 17, 2023 14:36
@AThousandShips AThousandShips added this to the 4.x milestone Oct 17, 2023
paulloz
paulloz approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@paulloz paulloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I scrolled quickly through the diff in generated sources, and couldn't see anything wrong 👍

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Mar 2, 2024
@akien-mga akien-mga merged commit 1598af5 into godotengine:master Mar 4, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Repiteo Repiteo deleted the c#-generator-langword-check branch March 4, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulloz paulloz paulloz approved these changes

Assignees
No one assigned
Labels
enhancement topic:buildsystem topic:dotnet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Repiteo @akien-mga @paulloz @AThousandShips