-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection related functionality to VisualShader (deleting, dropping/inserting a node) #83510
Conversation
Amazing! Do you think adding a knife tool would be hard to implement here? |
Not really so I might look into that, although it probably needs another method in GraphEdit to fetch all connections intersecting with a given line (using |
a92193a
to
6638759
Compare
6638759
to
4ab3c16
Compare
OMG YES! Thank you for this!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4ab3c16
to
9dd86d1
Compare
Needs a rebase, and a squash I think. |
9dd86d1
to
464bf4f
Compare
@YuriSizov Rebased, but this PR depends on #86158. That one needs to be merged first, this PR is already squashed and just based on the connections rework branch. |
Okay, I'll mark it as a draft for the time being then. |
464bf4f
to
5d40935
Compare
Rebased after #86158 got merged. Edit: Adjusted the commit message as well. |
75e9289
to
522cf6e
Compare
522cf6e
to
5cfc1e6
Compare
- Insert a node in a connection - Drop an unconnected node on a connection to insert it - Delete a connection
5cfc1e6
to
f59419b
Compare
Thanks! If there are further changes required in the VS plugin, we can do them in a follow-up. (And I personally still want this knife tool :P ) |
To demonstrate the new connection functionality, I went ahead and implemented some UX improvements for VS.
Depends on #86158 [merged]
#83508.TODO: