Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded documentation for vector slide and project #83691

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

theraot
Copy link
Contributor

@theraot theraot commented Oct 20, 2023

This pull request expands the documentation of Vector2.slide, Vector2.project, Vector3.slide and Vector3.project.

Based on godotengine/godot-proposals#8173 and godotengine/godot-docs#8286

Fixes godotengine/godot-docs#8286

@theraot theraot marked this pull request as ready for review October 20, 2023 18:48
@theraot theraot requested a review from a team as a code owner October 20, 2023 18:48
@AThousandShips AThousandShips added this to the 4.x milestone Oct 20, 2023
@esklarski
Copy link

esklarski commented Oct 21, 2023

I like it. It's clearer than my initial suggestion.

Copy link
Member

@kleonc kleonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked correctness, LGTM. 👍 Left some minor suggestions.

Also C# docs in Vector2.cs/Vector3.cs would need to be synced.

doc/classes/Vector2.xml Show resolved Hide resolved
doc/classes/Vector2.xml Outdated Show resolved Hide resolved
@theraot theraot requested a review from a team as a code owner October 23, 2023 06:14
@theraot
Copy link
Contributor Author

theraot commented Oct 23, 2023

I have updated Vector2.cs and Vector3.cs.

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have. If not for this PR, I would've gotten around writing something like this when it was time.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 26, 2024
@akien-mga akien-mga merged commit 9509a9e into godotengine:master Feb 26, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vector3.slide() needs expansion.
7 participants