Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Export] Use auto-increment build number in export versions. #83714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 21, 2023

Adds application/config/build project setting which is automatically incremented on successful export and used as (unless overridden in the export settings) iOS/macOS machine-readable version (CFBundleVersion), Android versionCode and 4-th component of app/file version on Windows.

See #83686 (comment)

@fire
Copy link
Member

fire commented Oct 21, 2023

How would I set this in cicd?

@bruvzg bruvzg marked this pull request as ready for review December 4, 2023 07:54
@bruvzg bruvzg requested review from a team as code owners December 4, 2023 07:54
@akien-mga
Copy link
Member

I'm not sure it's a good idea to auto-increment this number. The build number is an important piece of metadata for some platforms and here it would increase any time an export is done, including when exporting for different platforms one at a time. So the Windows, macOS, Linux, etc. builds would have a different number for what is technically still the exact same version of the project.

I think the build number is something users should still consciously increment - or at least there should be an option to choose if it should be auto-incremented on export or not.

In case it's not auto-incremented, we need to think about the UX so that it's still easy for users to change it when they do have project changes that they want reflected in a change of the build number.

Inferring it from VCS is also something that could be worth considering as an option, where e.g. for Git the build number could be the number of commits in the repo. This doesn't account for unstaged changes which would still affect the build though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants