Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure AnimationPlayer evaluate animations when autoplay is enabled and node becomes ready #83781

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Ensure AnimationPlayer evaluate animations when autoplay is enabled and node becomes ready #83781

merged 1 commit into from
Nov 14, 2023

Conversation

martinfelis
Copy link
Contributor

@martinfelis martinfelis commented Oct 22, 2023 •
edited by YuriSizov
Loading

Fixes #83326.

The issue was introduced in the refactoring done in 1b95827.

@martinfelis martinfelis requested a review from a team as a code owner October 22, 2023 15:03
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 22, 2023
@YuriSizov YuriSizov changed the title Ensure AnimationPlayer evaluate animations when autoplay is enabled a… Ensure AnimationPlayer evaluate animations when autoplay is enabled and node becomes ready Nov 13, 2023
TokageItLab
TokageItLab requested changes Nov 13, 2023
View reviewed changes
scene/animation/animation_player.cpp Outdated Show resolved Hide resolved
TokageItLab
TokageItLab approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@TokageItLab TokageItLab left a comment •
edited by YuriSizov
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs to squash.
https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html#the-interactive-rebase

@martinfelis
Ensure AnimationPlayer evaluate animations when autoplay is enabled a…
f04ec34 
…nd node becomes ready.

Fixes godotengine#83326.

The issue was introduced in the refactoring done in 1b95827.
@martinfelis martinfelis force-pushed the fix-animationplayer-ready-autoplay branch from ed88521 to f04ec34 Compare November 14, 2023 07:32
@akien-mga akien-mga merged commit 7c7d9e2 into godotengine:master Nov 14, 2023
14 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@martinfelis
Copy link
Contributor Author

Hooray! Keep it up!

@martinfelis martinfelis deleted the fix-animationplayer-ready-autoplay branch November 17, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TokageItLab TokageItLab TokageItLab approved these changes

Assignees
No one assigned
Labels
bug regression topic:animation
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Autoplay animation of AnimationPlayer starts one frame late
5 participants
@martinfelis @akien-mga @TokageItLab @YuriSizov @AThousandShips