Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hole in heightmap navigation mesh baking #83783

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Oct 22, 2023

Fixes hole in heightmap navigation mesh baking.

Fixes #80509.

Apparently the pr #76212 that was made to fix #76195 was wrong. I now tried with both MRPs with this pr and it fixes both for me. No "inexplicable holes" show up and the heightmap-from-texture also bakes its half-sphere correctly but more testers are welcome to finally close this heightmap bug-juggle-chapter.

@smix8 smix8 added this to the 4.2 milestone Oct 22, 2023
@smix8 smix8 force-pushed the inexplicable_hole branch from 70e5392 to ec800c6 Compare October 22, 2023 15:22
Fixes hole in heightmap navigation mesh baking.
@smix8 smix8 force-pushed the inexplicable_hole branch from ec800c6 to 9416f0c Compare October 22, 2023 16:23
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 8c25a98), it works as expected.

Before After (this PR)
Screenshot_20231022_232218 webp Screenshot_20231022_232154 webp

@akien-mga akien-mga merged commit 9123660 into godotengine:master Oct 23, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@smix8 smix8 deleted the inexplicable_hole branch October 23, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants