-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve and clarify texture filtering documentation #83907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Calinou
commented
Oct 24, 2023
- Mention the Use Nearest Mipmap Filter project setting.
- Fix nearest mipmap claiming to always use bilinear filtering (it uses trilinear filtering by default, like linear mipmap).
- See Allow specific materials to use bilinear mipmap filtering instead of trilinear godot-proposals#7411 (comment).
Calinou
added
bug
enhancement
documentation
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
labels
Oct 24, 2023
YuriSizov
approved these changes
Nov 13, 2023
YuriSizov
added
the
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
label
Nov 13, 2023
clayjohn
reviewed
Nov 14, 2023
- Mention the Use Nearest Mipmap Filter project setting. - Fix nearest mipmap claiming to always use bilinear filtering (it uses trilinear filtering by default, like linear mipmap).
Calinou
force-pushed
the
doc-texture-filter
branch
from
November 14, 2023 14:18
71077ff
to
47cadda
Compare
clayjohn
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I only read through the filters for BasteMaterial3D, I trust that they are the same in all 5 classes.
Thanks! |
Cherry-picked for 4.2.1. |
YuriSizov
removed
the
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
label
Dec 5, 2023
YuriSizov
removed
the
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
label
Jan 23, 2024
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.