-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only update EditorSceneTabs
tabs when necessary
#83957
Conversation
3b351c6
to
8e9dc96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some quick testing and seems to work correctly
8e9dc96
to
473c209
Compare
updated to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty great! Some lines related to global menus could probably be spread across multiple lines for readability, but that's not important right now.
Thanks! |
Fixes resizing rebuilds all tabs
Fixes updating scene unsaved state (basically every action) rebuilds all tabs
Fixes #81513
Fixes this TODO in editor_scene_tabs
update_scene_tabs
now resizes its tabs only if it needs to, instead of always clearing and adding one by one.added
_update_tab_titles
- updates the titles and icons of tabs. If the tab already has those values, it will not redraw.added
_scene_tabs_resized
- repositions the add button. Used when resizing.This could be optimized further by updating only the affected tab.
Needs testing on Mac to make sure the global menu works as expected. Particularly that it updates its name based on saved/unsaved state and that reordering tabs doesn't break it.