-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TTS_Linux: Fix size_t template issue on OpenBSD by using int consistently #84017
Conversation
With this (plus some other "usual" patches like the one for the sndio backed) I'm finally able to compile and run godot on OpenBSD! I wasn't sure about the cast, but we hit already a similar issue in the embedded copy of embree (https://github.com/openbsd/ports/blob/master/games/godot/patches/patch-thirdparty_embree_common_math_math_h). I guess that having To be fair I'm still not completely sure why it was failing to build before, I got the cast almost by chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p_client_id
is not used anywhere, so there's no need to pass it to deferred calls. And message ID is limited to int
range (in case events it should be always > 0, -1 is used for errors).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits, see Pull request workflow for details.
Sorry I should have mentioned this earlier: the commit message is incorrect since it's not using uint64_t anymore. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
Cherry-picked for 4.1.4. |
This is a follow-up of #83804. The issue was observed on OpenBSD where compilation failed because of a missing
GetTypeInfo<unsigned long>
template. Using uint64_t forTTS_Linux::_speech_index_mark()
andTTS_Linux::_speech_event()
arguments fixes this.Bugsquad edit: