Add foreign validation warning for rename actions. #84022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
reviewed
Oct 26, 2023
KoBeWi
reviewed
Oct 26, 2023
editor/scene_tree_dock.cpp
Outdated
| @@ -386,6 +389,9 @@ void SceneTreeDock::_tool_selected(int p_tool, bool p_confirm_override) { | |||
| if (!profile_allow_editing) { | |||
| break; | |||
| } | |||
| if (!_validate_no_foreign()) { | |||
There was a problem hiding this comment.
Previously this would fail silently instead, so this only adds a warning without preventing anything new. Although is useful for #69087
There was a problem hiding this comment.
It's been updated now to be inside the 'is_anything_selected' check, but yes, it doesn't prevent anything new, but it does make its behaviour consistent with the other actions in providing explicit feedback when a rename check fails.
KoBeWi
approved these changes
Oct 26, 2023
SaracenOne
force-pushed
the
validate_renames
branch
from
59c21be to
5deff6c
Compare
|
Updated to put the warning after the selection checks for both actions. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing validation checks for renaming foreign nodes, both regular renames and batch renames. Will prevent disallowed node renaming when using shortcuts.