Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Fix typo in ConcavePolygonShape2D/3D description #84111

Merged
merged 1 commit into from
Oct 30, 2023
Merged

doc: Fix typo in ConcavePolygonShape2D/3D description #84111

merged 1 commit into from
Oct 30, 2023

Conversation

EgeYildir
Copy link
Contributor

Fix a typo that said ConvexPolygonShape2D instead of ConcavePolygonShape2D. ConcavePolygonShape2D is hollow and both this page and ConvexPolygonShape2D page confirms it.

@EgeYildir EgeYildir requested a review from a team as a code owner October 28, 2023 13:06
@AThousandShips AThousandShips added bug documentation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 28, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 28, 2023
@AThousandShips
Copy link
Member

The same error is present in the 3D shape, can you fix that as well? Please update your code with git commit --amend to not create an additional commit

@akien-mga
Copy link
Member

The same error is present in the 3D shape, can you fix that as well? Please update your code with git commit --amend to not create an additional commit

Please also amend the commit message to be more explicit. See https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind. Here it could be "doc: Fix typo in ConcavePolygonShape2D/3D description"

@akien-mga akien-mga changed the title Update ConcavePolygonShape2D.xml doc: Fix typo in ConcavePolygonShape2D description Oct 28, 2023
@AThousandShips
Copy link
Member

AThousandShips commented Oct 29, 2023 •
edited
Loading

Please squash your commits into one, see here, and use git push --force to not add a merge commit

Also make the description: "doc: Fix typo in ConcavePolygonShape2D/3D description" note the 3D part

@AThousandShips AThousandShips changed the title doc: Fix typo in ConcavePolygonShape2D description doc: Fix typo in ConcavePolygonShape2D/3D description Oct 29, 2023
@EgeYildir
Copy link
Contributor Author

Sorry for inconvenience. This should be all good now.

@akien-mga akien-mga merged commit 6fe7a5e into godotengine:master Oct 30, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4. While the change is minor and will affect translations, this was blatantly and misleadingly wrong before. So I concluded that it was worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@EgeYildir @AThousandShips @akien-mga @YuriSizov