Improve NavigationServer NavMap sync error msgs #84278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
added
enhancement
topic:navigation
cherrypick:4.2
smix8
force-pushed
the
navmap_errors
branch
2 times, most recently
from
5fe9284 to
ccce64f
Compare
Scony
reviewed
Feb 20, 2024
Improves NavigationServer NavMap sync error msgs.
akien-mga
approved these changes
Feb 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves NavigationServer NavMap sync error msgs.
Adds more detail how to deal with those errors and makes them debug build only.
Makes the error only print once to not spam users with pages of error text that lag their scene starts. One error msg should be enough to get the info across.